Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't defer sdkM*Release task settings #2

Open
pledbrook opened this issue Apr 22, 2015 · 0 comments
Open

Can't defer sdkM*Release task settings #2

pledbrook opened this issue Apr 22, 2015 · 0 comments

Comments

@pledbrook
Copy link
Contributor

The plugin is currently too eager in checking settings, i.e. it's done at configuration time. This precludes fully dynamic configuration which can occur during the execution phase. A similar issue was raised for the Lazybones plugin.

My specific requirement is that I want to allow developers to install and test Lazybones locally without requiring credentials for Bintray and SDK.env. You only need those credentials when publishing a new release. To handle this case, I configure the credentials within a taskGraph.whenReady block. Unfortunately that's just not possible with the plugin currently.

pledbrook added a commit to pledbrook/gradle-sdkvendor-plugin that referenced this issue Apr 23, 2015
Fixes issue sdkman#2. All the tasks now have properties that need to be initialised
before the tasks can be used. Instead of having the tasks pull the required
information from the GVM extension, the plugin class performs the binding
between the extension and task properties.

This means that users can define their own GVM task instances and they can
also configure the convention-based ones at any time before execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant