Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.0.3 #131

Open
jrgriffiniii opened this issue Nov 29, 2021 · 8 comments
Open

Support Ruby 3.0.3 #131

jrgriffiniii opened this issue Nov 29, 2021 · 8 comments
Assignees

Comments

@jrgriffiniii
Copy link
Contributor

Derived from samvera/maintenance#77

@jrgriffiniii jrgriffiniii changed the title Support Ruby 3.0 releases Support Ruby 3.0.3 Mar 1, 2022
@jrgriffiniii
Copy link
Contributor Author

#135 (comment) must be addressed before this can be completed.

@jrgriffiniii jrgriffiniii self-assigned this Mar 4, 2022
@jrgriffiniii
Copy link
Contributor Author

Ldp::Client#head is somehow creating resources against the rdf-ldp server, but I am otherwise progressing with this upgrade.

@jrgriffiniii
Copy link
Contributor Author

Unfortunately, supporting Rails 6.0.z releases may well require that support for Ruby 2.5.z is dropped.

Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    rails (~> 6.0.0) was resolved to 6.0.4.7, which depends on
      actiontext (= 6.0.4.7) was resolved to 6.0.4.7, which depends on
        nokogiri (>= 1.8.5)

    ldp was resolved to 1.0.3, which depends on
      nokogiri (< 1.13, >= 1.12.5)

Trying to upgrade nokogiri, however, drops Ruby 2.5 support: https://rubygems.org/gems/nokogiri/versions/1.13.0

@jrgriffiniii
Copy link
Contributor Author

ced442e starts to finally advance this towards a better resolution. I am afraid that I needed to either replace the Faraday stubs outright with RSpec or default to lamprey from rdf/ldp.

@jrgriffiniii
Copy link
Contributor Author

https://github.com/samvera/ldp/compare/allow-ruby-3.0?expand=1 only has 5 integration tests failing for this solution.

@jrgriffiniii
Copy link
Contributor Author

I have discovered a few new bugs with this, but this has required me to test against a containerized deployment of fcrepo4: https://github.com/samvera/ldp/compare/allow-ruby-3.0-wip?expand=1

There are some outlying WebMock stubs triggering errors, but hopefully resolving this should require minimal effort.

@jrgriffiniii
Copy link
Contributor Author

a444773 should see this properly updated and passing now. I will see about squashing this, and updating (or deprecating) #145

@jrgriffiniii
Copy link
Contributor Author

b84e860 has this passing within my local development, however I still need to ensure that fcrepo4 is accessible for CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment