Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SentenceSplitter doesn't take care of excludedEmbedMetadataKeys #1098

Open
pserrer1 opened this issue Aug 2, 2024 · 1 comment
Open

SentenceSplitter doesn't take care of excludedEmbedMetadataKeys #1098

pserrer1 opened this issue Aug 2, 2024 · 1 comment

Comments

@pserrer1
Copy link
Contributor

pserrer1 commented Aug 2, 2024

The current SentenceSplitter has some issues with excludedEmbedMetadataKeys. The TextNodes created after the split containing the whole content including all metadata entries as text.

I'm not fully sure how this is supposed to work, but my naive assumption would be that MetadataAwarTextSplitter should use node.getContent(MetadataMode.NONE) instead of node.getContent(MetadataMode.ALL)
@pserrer1 pserrer1 mentioned this issue Aug 2, 2024
Merged
@himself65
Copy link
Member

Could you please add a test for the case? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@himself65 @pserrer1