Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prettier v3 #224

Closed
artola opened this issue Oct 15, 2023 · 2 comments
Closed

support prettier v3 #224

artola opened this issue Oct 15, 2023 · 2 comments
Labels
language server Upstream language server issue

Comments

@artola
Copy link

artola commented Oct 15, 2023

It should be possible to upgrade to Prettier v3 or support both: prettier: "^2.0.0 | ^3.0.0"

May be the only thing to care about is the change of the apis to async

// v2
export function format(source: string, options?: Options): string;
// v3
export function format(source: string, options?: Options): Promise<string>;

It seems that some used packages/services expect format to be sync.

@remcohaszing
Copy link
Owner

Prettier is integrated via yaml-language-server. There’s already a PR to update Prettier (redhat-developer/yaml-language-server#909). If that’s merged and released, monaco-yaml can update too.

@remcohaszing remcohaszing added the language server Upstream language server issue label Oct 15, 2023
@remcohaszing
Copy link
Owner

I’m closing this, as it’s currently not actionable. It really depends on the upstream issue being resolved and released.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language server Upstream language server issue
Projects
None yet
Development

No branches or pull requests

2 participants