Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste merlin logic into here #7

Open
chenglou opened this issue Jun 11, 2017 · 0 comments
Open

Paste merlin logic into here #7

chenglou opened this issue Jun 11, 2017 · 0 comments

Comments

@chenglou
Copy link
Contributor

If I'm not mistaken, the merlin editor logic is dynamically loaded from merlin https://github.com/ocaml/merlin/tree/master/emacs

The justification for vim/emacs dynamically loading the merlin plugin was so that merlin can evolve its commands and the plugins that call them at the same time, so that when you upgrade to a new merlin, your editor, on startup, loads the fresh new plugin.

Vim-reason used to do the same. I've since pulled out the plugin logic from vim and pasted it in the vim-reason plugin itself, because the dynamic loading thing wasn't working as reliably as we'd hoped. This means if merlin ever changes how its queries work when the editor plugin will need to be manually updated to match that new version. But that's a fine tradeoff since the Reason community isn't ready to arbitrarily upgrade merlin yet anyway. It also makes distributing precompiled merlin binaries easier, since the binaries obviously don't carry these plugins with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant