Sync this with the one in highlight.js

[chenglou]

cc @gmmorris. Thanks for your work! I've tweaked the logic a bit and made sure that 99% of reason docs' snippet render correctly.

Building highlight.js master isn't always possible; case in point, reason's doc site uses Docusaurus, so highlightjs is a transitive dependency. Pinning it to master using yarn/npm wouldn't work either, because you'd get the un-built highlight.js (aka no lib/ folder).

For this reason, I've split out the highlight for easier integration and iteration. The highlightjs folks seem to want to eject the plugins too anyway.

In the meantime, we should sync up the one in the highlightjs repo with this one. Or simply remove the former. What's your opinion?

[gmmorris]

Hey,
I'm happy either way, I wasn't aware of the fork, and simply wanted better highlighting for my blog.

I'll try and take a look in the next couple of days, but if you want to sync it up and were concerned I might take offence (that my work is being replaced), then worry not. 😋

[chenglou]

@gmmorris just made a few more improvements =)

Sorry to bother you, but have you seen highlightjs/highlight.js#1833 before? I'm trying to sync this back.

[gmmorris]

It's no bother, but sadly can't help, I haven't come across that.
It built well for me straight away, but my experience with highlights is limited to the reason work... Hadn't touched the project before that.

Good luck 😁

[joshgoebel]

[Highlight.js maintainer here] If this is the "canonical" grammar and maintained by ReasonML people then I'm inclined to remove the one we have in Highlight.js for many reasons:

• It seems quite buggy and it has not really been maintained over time.
• Lack of tests.
• Complex "parser" based approach vs simpler pattern matching.
• It uses lots of non-standard scopes that none of our themes support.

I was looking into fixing it, reducing the scopes, and bringing it up-to-date with the new work we're doing but if this already exists and all the ReasonML people in the know use it, then I think perhaps it should be removed from core entirely in favor of referring people here.

Thoughts?

[chenglou]

Hey Josh. Yeah that sounds good. Thanks!