Drop GetPublicKey(peer.ID)? #21
Labels
scope/required
Feature required to match go-libp2p-kad-dht
Comments
guillaumemichel
added
the
scope/required
|
2023-06-27 call: there was an agreement that the |
|
Given the above, does this mean that this issue can be closed from here? AFAIU, this is needed, but not in this repo and instead it's needed in: https://github.com/ipfs/boxo - @Jorropo do we have a tracking issue in boxo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/libp2p/go-libp2p-kad-dht is implementing a public
GetPublicKey(peer.ID)method. It isn't the role of the DHT to provide such a feature.https://github.com/libp2p/go-libp2p-kad-dht/blob/978cb74f5fdf846e09d5769bb4dfb9f962135c38/records.go#L19-L78
IMO this function doesn't need to be ported to the new implementation. If needed this function should be implemented directly in https://github.com/ipfs/boxo.
The text was updated successfully, but these errors were encountered: