-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension doesn't ignore formatting for gitignored files #3063
Comments
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
This is still an issue. The extension should be consistent with the prettier cli. |
This is a bigger task than it seems. This extension relies on the Prettier API, but since there were issues integrating with Prettier v3, they had to revert back to Prettier v2. This won't be fixed until Prettier v3 is supported again. |
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
keeping the issue open |
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
not stale |
i also have the same issue |
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
still relevant to me |
In my case
|
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
It looks like for now, we have only 2 options:
|
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
not stale |
Summary
prettier 3.0 introduced ignoring gitignored files by default, however the vscode extension doesn't ignore them, unlike
.prettierignore
d files. Using the prettier cli to format works fineGithub Repository to Reproduce Issue
https://github.com/h-projects/gasbot/tree/59d05a8df6a72a92a84fd0273e29c23e191eb2e7 (
.prettierignore
file is still in there)Steps To Reproduce:
.prettierignore
file and a.gitignore
file, both with the same contents.prettierignore
(it doesn't get formatted, good).prettierignore
fileExpected result
The file doesn't get formatted, just like if
.prettierignore
was presentActual result
The file gets formatted
Additional information
VS Code Version:
1.79.2
Prettier Extension Version:
9.19.0
OS and version:
Windows 10 22H2, prettier 3.0.0
Prettier Log Output
Before removing `.prettierignore`
After removing the `.prettierignore` file, but still having the affected file gitignored
The text was updated successfully, but these errors were encountered: