Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub2-mkconfig fail with composefs enabled #3198

Open
karuboniru opened this issue Feb 24, 2024 · 4 comments
Open

grub2-mkconfig fail with composefs enabled #3198

karuboniru opened this issue Feb 24, 2024 · 4 comments
Labels
area/composefs Issues related to composefs difficulty/medium medium complexity/difficutly issue reward/medium Fixing this will be notably useful triaged This issue has been evaluated and is valid

Comments

@karuboniru
Copy link

$ journalctl -b -3 -u ostree-finalize-staged.service --output=cat
Finished ostree-finalize-staged.service - OSTree Finalize Staged Deployment.
Stopping ostree-finalize-staged.service - OSTree Finalize Staged Deployment...
Finalizing staged deployment
Copying /etc changes: 16 modified, 8 removed, 138 added
Copying /etc changes: 16 modified, 8 removed, 138 added
Refreshing SELinux policy
Refreshed SELinux policy in 1820 ms
Finalized deployment
bootfs is sufficient for calculated new size: 149.2 MB
error: Bootloader write config: grub2-mkconfig: 子进程已退出,代码 1
ostree-finalize-staged.service: Control process exited, code=exited, status=1/FAILURE
ostree-finalize-staged.service: Failed with result 'exit-code'.
Stopped ostree-finalize-staged.service - OSTree Finalize Staged Deployment.
ostree-finalize-staged.service: Consumed 4.059s CPU time, no IP traffic.

子进程已退出,代码 1 should be translation of child process has exited with code 1.


manually running grub2-mkconfig gives:

$ sudo grub2-mkconfig -o /dev/null
/usr/sbin/grub2-probe: error: failed to get canonical path of `overlay'.

It seems that grub2-probe failed to understand the filesystem layout with composefs enabled.


Version

rpm -q ostree grub2-tools-minimal             
ostree-2024.3-2.fc40.x86_64
grub2-tools-minimal-2.06-118.fc40.x86_64
@cgwalters
Copy link
Member

This is also discussed in coreos/rpm-ostree#4664 (comment) but is probably better tracked here. Conceptually though it's a grub issue - and I'd recommend in general that people use static grub configs.

@cgwalters cgwalters added difficulty/medium medium complexity/difficutly issue triaged This issue has been evaluated and is valid reward/medium Fixing this will be notably useful area/composefs Issues related to composefs labels Feb 24, 2024
@karuboniru
Copy link
Author

I tried using sudo ostree config set sysroot.bootloader none and it killed my grub... Seems due to /boot/grub2/grub.cfg being a symlink to somewhere under /boot/loader which won't be generated anymore, it seems I installed this system before f37 (I can't really tell).

So, after applying the command try to check if this is the case for you.

@cgwalters
Copy link
Member

This one really wants containers/composefs#280

@cgwalters
Copy link
Member

Filed a bug with a patch at https://bugzilla.redhat.com/show_bug.cgi?id=2308594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/composefs Issues related to composefs difficulty/medium medium complexity/difficutly issue reward/medium Fixing this will be notably useful triaged This issue has been evaluated and is valid
Projects
None yet
Development

No branches or pull requests

2 participants