Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also return the runeID (block:tx) in on the output endpoints #3863

Open
pxr64 opened this issue Jul 17, 2024 · 3 comments · May be fixed by #3971
Open

Also return the runeID (block:tx) in on the output endpoints #3863

pxr64 opened this issue Jul 17, 2024 · 3 comments · May be fixed by #3971

Comments

@pxr64
Copy link

pxr64 commented Jul 17, 2024

Currently, the output endpoints only return the rune name and we need to make subsequent calls to return each rune ID.

@cryptoni9n
Copy link
Collaborator

cryptoni9n commented Jul 18, 2024

Currently, the output endpoints only return the rune name and we need to make subsequent calls to return each rune ID.

Hi @pxr64 - my feeling is that this is by design since neither the Rune ID nor the block:tx is shown on the output page in ord (example). Therefore ord doesn't currently consider it to be info about the output that it should return. If we want to add this data to the output page and the output endpoint, I think that would be fine. However, I'm not sure if this was left off purposefully as being superfluous or cluttering to the other information about the output. @raphjaph what do you think?

edit: maybe it would be a better addition to #3675?

@raphjaph
Copy link
Collaborator

I think we could probably add this to the JSON version of this endpoint.

@raphjaph raphjaph linked a pull request Sep 30, 2024 that will close this issue
@raphjaph
Copy link
Collaborator

Would something like this help?
#3971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants