Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor ConsensusContext Validate functions to remove the fake "context" #1555

Open
noambergIL opened this issue Apr 30, 2020 · 0 comments
Labels

Comments

@noambergIL
Copy link
Contributor

The validations here have a context that holds data and then used to have all the functions conform to same sig - somewhat nicer in the main func and maybe to cluster the tests.

However its not flexible, its weird to copy data just to have a single sig for funcs and anyways i've added functions that just don't conform.

Consider removing the rxValidtorContext and txValidatorContext and just calling the functions with the data they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant