Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Videos? #946

Open
shiffman opened this issue Apr 24, 2024 · 7 comments
Open

Incorporate Videos? #946

shiffman opened this issue Apr 24, 2024 · 7 comments
Assignees
Labels

Comments

@shiffman
Copy link
Member

Do we add them in the chapters themselves (new elements in Notion that are ignored for PDF build) or a separate page? Or just link to coding train site, hmmmmm.

@shiffman
Copy link
Member Author

First step is to design a mock-up of a few ideas that range from:

  • small, subtle YT play button (with chapter sub-heading?)
  • to, larger thumbnail of video itself or even YT embed player

@tuantinghuang
Copy link
Collaborator

@jasongao97 let me know if you need more specific details!

Inactive state
Screenshot 2024-06-01 at 16 24 54

Active state (when hovered )
Screenshot 2024-06-01 at 16 25 09

@shiffman
Copy link
Member Author

shiffman commented Jun 4, 2024

A tiny nitpicky comment but the space between the pink play button and "Video 1.1" looks quite wide, I might tighten that up a little bit?

@shiffman
Copy link
Member Author

The implementation is now completed with #985 but I need to go through and add all the videos! @tuantinghuang this is something I'm happy for you to work on we can discuss!

@tuantinghuang
Copy link
Collaborator

@shiffman Yes let's discuss! I'm happy to go through Notion and add the videos too!

@tuantinghuang
Copy link
Collaborator

@jasongao97 Is it okay to attach a video to an example? If so, where should I place the callout box?

Take this fractal tree - L system video as an example. I think it would be better to attach it next to example 8.9 on the website. Is it possible to place the video next to the example header?

Screenshot 2024-09-27 at 13 47 41

@tuantinghuang
Copy link
Collaborator

@shiffman I went through all videos on Nature of code track on the CT website. And here's a list of things that I'm unsure of!

  • Some video tracks that I don't know where to insert:

    • 3.7 Additive waves
    • 5.3 Pursue & Evade (if we can attach videos next to exercise 5.3 that would be ideal)
    • chapter 8: Object oriented fractal tree, Dragon Curve
    • chapter 10: XOR problem
  • Video 6.3 appeared on the website before 6.2, is that okay?

  • There are some videos that make sense to be watched together, can they be placed side by side? (Something like the attached image below) @jasongao97 Would you have any thoughts on this? Currently they are 2 consecutive video callout boxes in Notion.

    • 9.3 + 9.4 Shakespeare Monkey Example + code
    • 9.7 + 9.8 Pool Selection + Improve Pool Selection
    • Chapter 10: Perceptron Part 1 +2, Multilayer Perceptron Part 1 + 2

Screenshot 2024-09-27 at 14 20 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants