Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework text parsing #5

Open
nadako opened this issue Apr 5, 2016 · 0 comments
Open

Rework text parsing #5

nadako opened this issue Apr 5, 2016 · 0 comments

Comments

@nadako
Copy link
Owner

nadako commented Apr 5, 2016

Right now, when parsing text, we add a Text token for each character, marking whitespace ones, setting them to null and then squashing them into one Text token. This was ported from mustache.js and is needed to handle stand-alone tags on line.

I don't like it as it creates a lot of garbage and generally feels quite hacky, so I need to think of some better way to handle all this. Reworking this might accidentally fix disabled spec tests mentioned in #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant