Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build script to prevent release failure #316

Open
yfakariya opened this issue Feb 3, 2019 · 0 comments
Open

Update build script to prevent release failure #316

yfakariya opened this issue Feb 3, 2019 · 0 comments
Labels
enhancement Requires or request to feature enhancement

Comments

@yfakariya
Copy link
Member

Currently, there are some legacy techniques for build artifact versioning, it caused release failure of 1.0.1.

We should fix build scripts to use more simple and modern matter for versioning.

  • The script should take advantage git tag if its format matches to semver.
  • All version related parameters should be managed in common msbuild project file which will be refered from Directory.build.props
    • AssemblyFileVersion should be handled in it.
  • The script should be run without MSBuild.exe
  • The script should be run on pwsh
@yfakariya yfakariya added the enhancement Requires or request to feature enhancement label Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requires or request to feature enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yfakariya