Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log non-200 OK responses separately and alert accordingly #212

Open
stevejalim opened this issue May 22, 2023 · 0 comments
Open

Log non-200 OK responses separately and alert accordingly #212

stevejalim opened this issue May 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@stevejalim
Copy link
Collaborator

At the moment, we call raise_for_status() after checking a URL to ensure it's a 200. This also is a crude way of catching 404s and 500s in the site -- if the status-check fails, the overall batch/job fails. So, it gets communicated because of the error, but it's a bit sledgehammer vs nut.

Instead, we should gather non-200 OK responses, log them to an output file and then report/fail/alert on those in the final reporting step.

@stevejalim stevejalim added the enhancement New feature or request label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant