Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basket should return an error when passing unknown data #904

Open
alexgibson opened this issue Sep 14, 2022 · 0 comments
Open

Basket should return an error when passing unknown data #904

alexgibson opened this issue Sep 14, 2022 · 0 comments

Comments

@alexgibson
Copy link
Member

Ran into this error recently whilst working on mozilla/bedrock#11944

When posting incorrect labelled data to /news/subscribe/ (in this case it was fmt=H instead of format=H), basket gives a success message but then fails silently and does not generate a confirmation email. Instead, it should return an error so it's clear to clients that something went wrong.

Expected result:

{"status": "error", "desc": "Unknown data"} (or something along these lines)

Actual result:

{"status": "ok"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant