Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer to version 23.4.0 #18773

Open
timvandermeij opened this issue Sep 22, 2024 · 2 comments
Open

Update puppeteer to version 23.4.0 #18773

timvandermeij opened this issue Sep 22, 2024 · 2 comments

Comments

@timvandermeij
Copy link
Contributor

In #18771 we found that updating Puppeteer from version 23.3.0 to 23.4.0 caused new test failures. This is also reproducible locally. The logs from the bots can be found at http://54.193.163.58:8877/f9b8d1c303f789c/output.txt (Windows) and http://54.241.84.105:8877/902fcf449da1c69/output.txt (Linux). Version 23.3.1 doesn't have this issue locally, so we need to investigate what changed between 23.3.1 and 23.4.0 that causes some tests to fail and/or harden the tests against (intermittent) failure.

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Sep 22, 2024

I have compared the Puppeteer 23.3.1 release with the Puppeteer 23.4.0 release and found the following commits: puppeteer/puppeteer@puppeteer-v23.3.1...puppeteer-v23.4.0. There isn't really much interesting in there other than the Chrome update, and in the logs above I noticed that the failures are all in Chrome. However, the problems in Chrome might point to pre-existing issues in the tests themselves that only surface now.

@jamesgpearce
Copy link

Unrelated to pdf.js but I am also getting unusual errors from 23.4 relative to 23.3. Basic things like not being able to connect to the server for the first few tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants