You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Click the yellow popup annotation in order to expand it
Click within the pdf viewer to make sure it's active
Press Ctrl-F to bring up the search text box
Type in "seashells"
Observe that the find module reports "phrase not found"
Click within the address bar of the browser
Press Ctrl-F to bring up the browser's search text box
Type in "seashells"
Observe that one of the search match results is the text within the expanded popup annotation
What is the expected behavior?
PDF.JS's search module finds the matching "seashells" phrase in the expanded popup annotation.
What went wrong?
PDF.JS's search module does not find the matching "seashells" phrase in the expanded popup annotation.
Link to a viewer
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
garydeng01
changed the title
[Bug]: "Find" doesn't detect text matches in popup annotations
[Bug]: "Find" doesn't match text in popup annotations
Aug 9, 2024
Do you expect it to search also in annotations that are not open (those that only open when you pass the mouse on them), or in all of them?
This seems interesting and if the maintainers like the feature I will probably submit a PR at some point, but maybe it should be opt-in through a checkbox in the search bar,
Do other PDF Viewers even support something like this, since this really does seem like something that could add a whole bunch of additional complexity to the find implementation!?
Do you expect it to search also in annotations that are not open (those that only open when you pass the mouse on them), or in all of them?
This seems interesting and if the maintainers like the feature I will probably submit a PR at some point, but maybe it should be opt-in through a checkbox in the search bar,
For my use case, I would prefer that the search includes the popup annotations that are not open. Perhaps navigating to such a match would then open the popup and highlight the text within? I'm not sure what most users would prefer, but this seems like a reasonable way for it to function.
Attach (recommended) or Link to PDF file
popup_example.pdf
Web browser and its version
Chrome 124.0.6367.92
Operating system and its version
Windows 10 Enterprise 22H2
PDF.js version
v4.5.136
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem
What is the expected behavior?
PDF.JS's search module finds the matching "seashells" phrase in the expanded popup annotation.
What went wrong?
PDF.JS's search module does not find the matching "seashells" phrase in the expanded popup annotation.
Link to a viewer
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: