Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating grasps off-object or for only half the object with non-cubes [possible solution] #107

Open
Au3f opened this issue Apr 29, 2022 · 0 comments

Comments

@Au3f
Copy link

Au3f commented Apr 29, 2022

When using the TwoFingerGraspGenerator to generate face-grasps from the top for objects that are not cubes there is an odd behavior:

  • Objects that are taller than wide will result in grasps generated next to the object (mid air)
  • Objects that are wider than tall will only have grasps for a part of their dimensions (exactly their height)

It looks like the dimensions or number of grasps along the faces got mixed up somehow.

After further investigation, i think i found the Problem: In two_finger_grasp_generator.cpp at line 410,422,508 and 520 num_grasps_along_a should be passed to addEdgeGraspsHelper instead of num_grasps_along_b.

These modifications fixed the issue for me.
Hopefully someone of you can verify the Solution and maybe add this as a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant