Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare selected files in explorer view seems to be broken on Win32 #63

Open
GitMensch opened this issue Jan 4, 2022 · 7 comments
Open
Assignees
Labels
help wanted Extra attention is needed

Comments

@GitMensch
Copy link

  • go to Explorer-view
  • select two files
  • open context-menu
  • see "[Diff & Merge] Compare selected files" and click on it
  • nothing seems to happen

The protocol from extension host shows

[error] Error: ENOENT: no such file or directory, open '\root\dir\file.ext' 
	at Object.openSync (fs.js:466:3)
	at Object.func [as openSync] (electron/js2c/asar_bundle.js:5:1812)
	at Object.readFileSync (fs.js:368:35)
	at Object.e.readFileSync (electron/js2c/asar_bundle.js:5:8583)
	at getContentOrFallback (c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\content.js:77:26)
	at Object.getExplorerSides (c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\content.js:33:26)
	at c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\commands.js:71:65
	at Generator.next (<anonymous>)
	at c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\commands.js:8:71
	at new Promise (<anonymous>)
	at __awaiter (c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\commands.js:4:12)
	at fileDiff (c:\Users\me\.vscode-oss\extensions\moshfeu.diff-merge-0.5.2\out\commands.js:57:16)
	at S._executeContributedCommand (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:86:106770)
	at S.$executeContributedCommand (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:86:107208)
	at c._doInvokeHandler (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:90:12794)
	at c._invokeHandler (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:90:12478)
	at c._receiveRequest (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:90:11145)
	at c._receiveOneMessage (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:90:9931)
	at D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:90:8032
	at _.fire (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1836)
	at E.fire (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:15496)
	at D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:105:30083
	at _.fire (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1836)
	at E.fire (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:15496)
	at t._receiveMessage (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:20754)
	at D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:17640
	at _.fire (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:57:1836)
	at acceptChunk (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:12861)
	at D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:65:12209
	at Socket.w (D:\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:105:13173)
	at Socket.emit (events.js:315:20)
	at addChunk (_stream_readable.js:295:12)
	at readableAddChunk (_stream_readable.js:271:9)
	at Socket.Readable.push (_stream_readable.js:212:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:186:23) diffMerge.compareSelected

The file is located at "X:\root\dir", but the directory path is not in the argument.

@moshfeu
Copy link
Owner

moshfeu commented Jan 15, 2022

Thank you for noticing!
I don't have a machine with Win32 but I'll try to get one with by a virtual machine.
What version of windows are you using?

@moshfeu moshfeu self-assigned this Jan 15, 2022
@GitMensch
Copy link
Author

What version of windows are you using?

Shouldn't matter, I guess it is all the same. The most relevant targets are likely Win10, then Win11, then some Windows server, but as noted this likely happens in all the same way.

@moshfeu
Copy link
Owner

moshfeu commented Jan 26, 2022

So far I didn't have the chance to work on that so if someone has windows and can help fixing it, that would be awesome.

@moshfeu moshfeu added the help wanted Extra attention is needed label Jan 26, 2022
@stale
Copy link

stale bot commented Mar 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 28, 2022
@stale stale bot closed this as completed Apr 6, 2022
@GitMensch
Copy link
Author

Hey bot, that was too fast - it is definitely still an open issue and as many people still use Windows clients likely one that should be fixed and kept open until this is solved.

@moshfeu moshfeu reopened this Apr 7, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 7, 2022
@stale
Copy link

stale bot commented Jun 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 10, 2022
@GitMensch
Copy link
Author

Maybe the bot can be adjusted to don't add wontfix labels if another label is in, possibly something like helpwanted.

@stale stale bot removed the wontfix This will not be worked on label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants