Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/156 #288

Closed
wants to merge 3 commits into from
Closed

Feat/156 #288

wants to merge 3 commits into from

Conversation

mauroerta
Copy link
Collaborator

Proposed changes

Added support for keyframes and animations.

Minor:

  • fixed gradient inside the package @morfeo/preset-default

Closes #156

Types of changes

  • 🐛 Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality or enhancements)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ✅ Tests (added tests for an existing feature)
  • 📚 Documentation Update (if none of the other choices apply)
  • 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

  • 👀 I have read the CONTRIBUTING doc
  • ✅ Lint and unit tests pass locally with my changes
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • 📚 I have added necessary documentation (if appropriate)
  • 🔀 Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #288 (1f3e01c) into main (5544f3d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           98       105    +7     
  Lines          839       904   +65     
  Branches       110       120   +10     
=========================================
+ Hits           839       904   +65
Impacted Files Coverage Δ
packages/cli/src/constants/theme.ts 100.00% <ø> (ø)
packages/preset-default/src/base/gradients.ts 100.00% <ø> (ø)
packages/web/src/properties/pseudos.ts 100.00% <ø> (ø)
packages/cli/src/constants/maps.ts 100.00% <100.00%> (ø)
packages/cli/src/utils/buildTheme.ts 100.00% <100.00%> (ø)
packages/cli/src/utils/getClassesCSS.ts 100.00% <100.00%> (ø)
packages/cli/src/utils/getKeyFrames.ts 100.00% <100.00%> (ø)
packages/cli/src/utils/parseSlice.ts 100.00% <100.00%> (ø)
packages/jss/src/getKeyframesStyle.ts 100.00% <100.00%> (ø)
packages/jss/src/getStyleElement.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5544f3d...1f3e01c. Read the comment docs.

@mauroerta mauroerta marked this pull request as draft September 19, 2022 06:52
@mauroerta mauroerta closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ feat: Support Animation
2 participants
@mauroerta @codecov-commenter