Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported Lagom projects fail to start and get stuck in the Starting state. #35

Open
sishida opened this issue Nov 15, 2018 · 11 comments
Open

Comments

@sishida
Copy link
Collaborator

sishida commented Nov 15, 2018

Issue type: Bug
Reported in: Microclimate 18.10
Internal issues: dev-ex/portal issue 593 and dev-ex/dev-ex-planning issue 716
Fixed in:

Description of issue: If a project does not have a route handler for or returns an error status from GET /, it remains in the Starting state. For example, an imported Lagom template project remains in this state. If an old image from a previous project didn't get deleted, a project with the same name gets stuck in the Starting state.
Workaround: To access the application, open the project in Microclimate. On the Overview page, click the Application URL.

Status updates:

@tetchel
Copy link

tetchel commented Nov 20, 2018

We have to give more detail about what "the URL" is, especially given that the Open App page won't work if the project is stuck Starting. We should point the user to the application URL on the Overview page.

@sishida
Copy link
Collaborator Author

sishida commented Nov 20, 2018

@tetchel I have re-written the Workaround section. Please let me know if the edits will suffice or if you'd like additional changes. Thank you! :)

@tetchel
Copy link

tetchel commented Nov 20, 2018

I think it can be made a lot more concise. I would recommend:

Remove "in your browser" from the first sentence - this is implied by "open the project in Microclimate".

I think the second sentence is not necessary. The Overview page is already the page the user will see when they "open the project in Microclimate", plus we mention the Overview page in the next sentence.

Change "manually visit" to "click", capitalize the "A" in "Application URL" to point the user to that Overview section, and remove "instead of accessing the application through Microclimate", I don't think it's necessary.

To access the application, open the project in Microclimate. 
On the project's Overview page, click the Application URL link.

Let me know how that sounds.

@sishida
Copy link
Collaborator Author

sishida commented Nov 20, 2018

Changes made. Thanks! :)

@tetchel
Copy link

tetchel commented Nov 20, 2018

To be clear, this is project-type agnostic, ie not specific to Lagom projects. This will happen with any project that does not have a route handler for, or returns an error status from, GET /. We are working on a fix for this internally but it will not be out for some time.

@sishida
Copy link
Collaborator Author

sishida commented Nov 20, 2018

@tetchel Thanks for the clarification. I've removed the specification of Lagom and added the updated info to the original comment.

@tetchel
Copy link

tetchel commented Nov 20, 2018

It is also not specific to the import scenario. A user could create one of our template projects, remove the root route handler, and then this behaviour would be observed. I'm also not sure now how the first sentence in the description ties into the second now.

Sorry for all the comments, this is a relatively complex issue.

@sishida
Copy link
Collaborator Author

sishida commented Nov 20, 2018

OK, I removed the mention of imported. :)

@elsony
Copy link

elsony commented Nov 20, 2018

The problem does not happen for Lagom project type only as Tim mentioned. Therefore, I suggest to turn this to a generic message like Tim suggested but in the message, we also provide an example of the importing a Lagom project to explicitly call out that example since we know for sure that scenario will fail.

@tetchel
Copy link

tetchel commented Nov 20, 2018

Like Elson says, it would be good to add a second sentence that clarifies this will always happen when the user imports the Lagom template project.

In addition, for the first sentence, we can change "it might" -> "it will" - this will always happen if that route returns an error. Also, we want to avoid using the word "stuck" - we could say "it will remain in the Starting state"

@sishida
Copy link
Collaborator Author

sishida commented Nov 20, 2018

Updates added. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants