Why is the data not optional in ExecutionResult?

[huihuisang]

According to the description found in http://spec.graphql.org/October2021/#sec-Response-Format, the data will be null. Therefore, if the data is null, the data.decode process will fail.

[maticzav]

The TypeLock selection should already account for nullability and AnyCodable correctly manages nil values.

From the tests and my experience, it should work correctly. Did you find a bug or just curious why it is like that?

[huihuisang]

Code like this:

var request = URLRequest(url: url)
request.query(selection, as: operationName)
request.timeoutInterval = 20
request.setValue(defaultUserAgent, forHTTPHeaderField: "User-Agent")
do {
    let (data, response) = try await session.data(for: request)
    switch response.statusCode {
    case 200 ..< 300:
        let result = try data.decode(selection)
        return (result.data, response)
    default:
        …
    }

} catch {
    …
    Log.error(error)
}

[maticzav]

Thanks, could you add the selection part as well - that's the more important one. 🙂

[huihuisang]

It doesn't seem important? I changed to the simplest selection and used it to test with the returned data, but the same error occurred. The selection code like this:

let selection =  Selection.Query {
            try $0.media(id: id,
                         selection: Selection.Media {
                             Media(id: try $0.id())
                         }.nullable)
        }

[maticzav]

@huihuisang thank you for bringing this up and being so patient with me. You are correct that this was indeed an unhandled edge case.

To give you a bit of context, as I described in the PR, I think it's still better to specify data as non-nullable because otherwise, we need to modify a lot of code to account for the possibility of data being nil and that collides with the TypeLocks which resolve nil values themself, but I took it for granted that missing fields would work as well.

Thanks!

#144

[huihuisang]

You're welcome! Thank you for providing the context and explaining your perspective.
May I ask why the new code library has a minimum requirement of only supporting iOS 15? My project currently supports a minimum of iOS 14.😂

[maticzav]

#136

I know it's not ideal, but I considered that almost no iPhone has iOS 14 anymore (https://www.statista.com/statistics/565270/apple-devices-ios-version-share-worldwide/).

If you gravely need support because you are developing explicitly for iOS 14, I can adjust the parts as a paid feature request 🙂

[huihuisang]

Thank you for your response. I understand.