From 73a0f72ffa48522229579ec55dabd8022332070e Mon Sep 17 00:00:00 2001
From: Martin von Zweigbergk <martinvonz@google.com>
Date: Sun, 13 Mar 2022 22:48:29 -0700
Subject: [PATCH] github: new attempt at setting up automated release builds
 (#73)

My attempt at using rust-build/rust-build.action for release builds
(from bf21e65c5df8) initially seemed promising. However, the produced
musl binary build segfaulted on my Debian machine. I don't know about
the Mac and Windows binaries. I then tried switching to building with
a vendored OpenSSL (cac93e279393), but then the build started failing
(https://github.com/martinvonz/jj/actions/runs/1978730621). I couldn't
figure out why it failed, so I decided to do the build in a more
manual way (without rust-build/rust-build.action), based on
https://github.com/gitext-rs/git-stack/blob/main/.github/workflows/post-release.yml
(thanks to @epage for the example and to @arxanas for the link). I
could simplify it a bit because I'm currently doing the releases via
the GitHub UI (epage's original triggers the release when a tag has
been pushed, IIUC). Let's hope that it works this time.
---
 .github/workflows/release.yml | 75 ++++++++++++++++++++++++++---------
 1 file changed, 57 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 373af2cc53..7eda456678 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,29 +1,68 @@
-# .github/workflows/release.yml
-
+name: Release
 on:
   release:
     types: [created]
-
 jobs:
-  release:
-    name: release ${{ matrix.target }}
-    runs-on: ubuntu-latest
+  build-release:
+    name: build-release
     strategy:
       fail-fast: false
       matrix:
+        build: [linux-musl, macos, win-msvc]
         include:
-        - target: x86_64-pc-windows-gnu
-          archive: zip
-        - target: x86_64-unknown-linux-musl
-          archive: tar.gz tar.xz
-        - target: x86_64-apple-darwin
-          archive: zip
+        - build: linux-musl
+          os: ubuntu-20.04
+          target: x86_64-unknown-linux-musl
+        - build: macos
+          os: macos-11
+          target: x86_64-apple-darwin
+        - build: win-msvc
+          os: windows-2022
+          target: x86_64-pc-windows-msvc
+    runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@master
-    - name: Compile and release
-      uses: rust-build/rust-build.action@latest
+    - name: Checkout repository
+      uses: actions/checkout@v3
+    - name: Install packages (Ubuntu)
+      if: matrix.os == 'ubuntu-20.04'
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y --no-install-recommends xz-utils liblz4-tool musl-tools
+    - name: Install Rust
+      uses: actions-rs/toolchain@v1
+      with:
+        toolchain: stable
+        profile: minimal
+        override: true
+        target: ${{ matrix.target }}
+    - name: Build release binary
+      uses: actions-rs/cargo@v1
+      with:
+        command: build
+        args: --target ${{ matrix.target }} --verbose --release
+    - name: Build archive
+      shell: bash
+      run: |
+        outdir="./target/${{ matrix.target }}/release"
+        staging="jj-${{ github.event.release.tag_name }}-${{ matrix.target }}"
+        mkdir -p "$staging"/complete
+        cp {README.md,LICENSE} "$staging/"
+        if [ "${{ matrix.os }}" = "windows-2022" ]; then
+          cp "target/${{ matrix.target }}/release/jj.exe" "$staging/"
+          cd "$staging"
+          7z a "../$staging.zip" .
+          echo "ASSET=$staging.zip" >> $GITHUB_ENV
+        else
+          cp "target/${{ matrix.target }}/release/jj" "$staging/"
+          tar czf "$staging.tar.gz" -C "$staging" .
+          echo "ASSET=$staging.tar.gz" >> $GITHUB_ENV
+        fi
+    - name: Upload release archive
+      uses: actions/upload-release-asset@v1.0.1
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        RUSTTARGET: ${{ matrix.target }}
-        EXTRA_FILES: "README.md LICENSE"
-        ARCHIVE_TYPES: ${{ matrix.archive }}
+      with:
+        upload_url: ${{ github.event.release.upload_url }}
+        asset_path: ${{ env.ASSET }}
+        asset_name: ${{ env.ASSET }}
+        asset_content_type: application/octet-stream