Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-adapter-static also creates dynamic directories names as static folders #64

Open
Jack5079 opened this issue Apr 13, 2024 · 1 comment

Comments

@Jack5079
Copy link

Jack5079 commented Apr 13, 2024

https://github.com/Jack5079/marko-slug-bug

<!-- +page.marko -->
<a href="/path">path</a>
<!-- $+page.marko -->
<h1>here be $</h1>

Results in

dist
├── $
│   └── index.html
├── 404
│   └── index.html
├── path
│   └── index.html
└── index.html

But it should be:

dist
├── 404
│   └── index.html
├── path
│   └── index.html
└── index.html
@Jack5079 Jack5079 changed the title run-adapter-static creates dynamic directories as static folders run-adapter-static also creates dynamic directories names as static folders Apr 13, 2024
@DylanPiercey
Copy link
Contributor

Good catch @Jack5079, I think we need to add some more checks here https://github.com/marko-js/run/blob/main/packages/adapters/static/src/index.ts#L86

Will try to get to it once I have a sec. If you want to take a stab at a PR that'd be great also 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants