Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose output of file offsets and virtual addresses for language-specific strings #1019

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Arker123
Copy link
Collaborator

This PR enhances the verbose output to display raw file offsets and virtual addresses for Rust strings.

Fixes: #925 #937

*The PR is in draft status because it currently only supports Rust strings.

image

@Arker123 Arker123 requested a review from mr-tz June 23, 2024 15:14
@williballenthin
Copy link
Collaborator

do you think we should add column headers?

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this handle strings outside of .rdata?

alternative, we could consider adding a virtual offset field (and section info) to the StaticString class

floss/language/rust/extract.py Outdated Show resolved Hide resolved
@Arker123
Copy link
Collaborator Author

Currently looks like this in verbose:-
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]The offset of the RUST STRINGS is misaligned.
3 participants