Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reflection #50

Open
stephen-dahl opened this issue Oct 19, 2018 · 6 comments
Open

Implement Reflection #50

stephen-dahl opened this issue Oct 19, 2018 · 6 comments
Assignees

Comments

@stephen-dahl
Copy link

stephen-dahl commented Oct 19, 2018

Hi, good work with this so far!

Mali should support reflection once it is implemented in the core lib
https://github.com/grpc/grpc/blob/master/doc/server-reflection.md
grpc/grpc#2568

Or sooner if you dont need them :)

@bojand
Copy link
Member

bojand commented Oct 20, 2018

Yes this would be useful, and will implement once it's in the core grpc library.

@bojand bojand self-assigned this Oct 20, 2018
@kashifmin
Copy link

Has this been implemented yet ? @bojand

@bojand
Copy link
Member

bojand commented Mar 21, 2019

Hello, thank you for inquiring about this issue. This is not implemented yet as the core grpc Node.js module does not support reflection yet.

@lalomartins
Copy link

Does core actually need to support it first? Python and C++ have reflection as separate packages, and AIUI the js structures created either by dynamic or static should already have all the metadata (descriptors) needed by reflection. The ticket in the core lib mentions it can be done as a separate library.

Bonus: that means Mali can probably also have it as an optional add-on mali-reflection, so you only get it if you specifically want it.

@ansarizafar
Copy link

Any there any new update on this issue?

@ansarizafar
Copy link

It seems that Reflection can be implemented without support in core grpc library grpc/grpc-node#79 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants