Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude $ for salt value #75

Open
loafoe opened this issue Apr 22, 2024 · 1 comment
Open

Exclude $ for salt value #75

loafoe opened this issue Apr 22, 2024 · 1 comment

Comments

@loafoe
Copy link
Owner

loafoe commented Apr 22, 2024

See #74

@zoomoid
Copy link
Contributor

zoomoid commented Apr 22, 2024

While adding a validation for this should be easy, your usage example generally relies on random_password resources. If you just puzzle these parts together, and throw an error from inside this provider, it might be intransparent why it failed, because no user actually created that salt consciously. If you just "expect" the random_password to be "correct", and then have the provider error, this might confusion for the actual user.

Those are just my few cents from a UX standpoint, I generally welcome the change in terms of safety :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants