Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2-compat builds with SDL_JOYSTICK_DISABLED #52

Open
1bsyl opened this issue Feb 7, 2023 · 3 comments
Open

sdl2-compat builds with SDL_JOYSTICK_DISABLED #52

1bsyl opened this issue Feb 7, 2023 · 3 comments

Comments

@1bsyl
Copy link
Contributor

1bsyl commented Feb 7, 2023

not sure why it builds with SDL_JOYSTICK_DISABLED

so that ./testjoystick prints:
ERROR: SDL compiled without Joystick support.

@1bsyl
Copy link
Contributor Author

1bsyl commented Feb 10, 2023

maybe because it uses SDL_config_minimal ...

include/SDL2/SDL_config_ngage.h:#define SDL_JOYSTICK_DISABLED   1
include/SDL2/SDL_config.h.cmake:#cmakedefine SDL_JOYSTICK_DISABLED @SDL_JOYSTICK_DISABLED@
include/SDL2/SDL_config.h.in:#undef SDL_JOYSTICK_DISABLED
include/SDL2/SDL_config_minimal.h:#define SDL_JOYSTICK_DISABLED   1
include/SDL2/SDL_config_winrt.h:#define SDL_JOYSTICK_DISABLED 1

@madebr
Copy link
Contributor

madebr commented Feb 10, 2023

This fixme is related:

sdl2-compat/CMakeLists.txt

Lines 568 to 569 in 2c8012a

# FIXME: how to handle SDL_config.h? Generate a new one from SDL_config.h.cmake? Copy SDL_config.h + SDL_config_xxxxx.h?
install(FILES "${_hdr}" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/SDL2")

SDL3 eliminated installation of generated headers.
I think the sdl2-compat headers should assume everything is available, and internally fail those functions if dlsym cannot find something.

@FZXizzbKv7jg
Copy link

How can I build sdl2-compat with joystick support enabled?
Is that possible at the moment?
Installed sdl3 and sdl2-compat from aur last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants