Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NuGet package for kaitai csharp runtime #6

Open
orenht opened this issue May 3, 2017 · 12 comments
Open

Create NuGet package for kaitai csharp runtime #6

orenht opened this issue May 3, 2017 · 12 comments

Comments

@orenht
Copy link

orenht commented May 3, 2017

No description provided.

@Arlorean
Copy link
Contributor

I'll give this a go now. How hard can it be? :)

@GreyCat
Copy link
Member

GreyCat commented Jan 21, 2018

Shouldn't be that hard. If you know how to do that — you're most welcome to give it a shot :)

@Arlorean
Copy link
Contributor

OK. I've uploaded KaitaiStruct.Runtime.CSharp.0.7.0.nupkg file to nuget.org:

https://www.nuget.org/packages/KaitaiStruct.Runtime.CSharp/0.7.0

The changes are all in my local repository.
Let me know if you're OK with it and I'll send a pull request.

You can create a new package on the command line in Windows by downloading nuget.exe to the same directory as the .csproj and typing this in a Developer Command Prompt in that directory:
> nuget pack

Here's what it looks like in my VisualStudio when I was testing it locally. My .sln file was called KaitaiVox so you can ignore those references in the image:
https://drive.google.com/file/d/1pJYVkPP63y-xO2Wz9cj0duzG-rNbJoMV/view?usp=sharing

@Arlorean
Copy link
Contributor

Arlorean commented Jan 21, 2018

Done. Sorry I didn't put the #6 issue number in the commit comments.
PR is at #7

@GreyCat
Copy link
Member

GreyCat commented Jan 21, 2018

Actually, there is one more thing that concerns me now: how do we publish these? Is it possible to somehow register a team account or something, to publish something from a team's name, like "officially"? I see that, for example, Google's packages look like that: https://www.nuget.org/packages/Google.Protobuf/ <= i.e. with "The ID prefix of this package has been reserved for one of the owners of this package by NuGet.org." and it comes from special protobuf-packages account...

@Arlorean
Copy link
Contributor

Excellent question. Publishing was very easy, just a drag and drop of the nupkg file into the browser and fill in a few fields. I set up a personal account but I’m sure you can up an official Kaitai one. I’m happy to hand over the package name and Renaming it to Kaitai.Struct.Runtime makes sense. I can setup the NuGet account if you like. It just needs a verifiable email address.

Sent with GitHawk

@GreyCat
Copy link
Member

GreyCat commented Jan 22, 2018

Just got https://www.nuget.org/profiles/kaitai registered, I'll try to publish "official" v0.7 shortly. @Arlorean, if you feel like supporting that NuGet package and publishing it, let me know, I can send you the login/password for that account. Ideally, it would be super cool if we'll set up Travis CI to publish "unstable" runtime build every time code is changed in CI, if that's possible.

@arekbulski
Copy link
Member

I need your advise on #9

@mishun
Copy link

mishun commented May 13, 2019

Hi!
I've noticed that when using nuget package with .net core project following warning appears:

warning NU1701: Package 'KaitaiStruct.Runtime.CSharp 0.7.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project.

I tested it under .net core linux and it appear to actually work correctly, but the warning is annoying. Since from what it looks the library uses only very basic .net stuff, updating csproj file should probably be enough to fix that.

@GreyCat
Copy link
Member

GreyCat commented May 13, 2019

@mishun Please consider contributing a PR that will fix that csproj file to make it work the way you want it.

@KOLANICH
Copy link

@pluskal pluskal mentioned this issue Nov 13, 2019
@pluskal
Copy link
Contributor

pluskal commented Dec 12, 2019

I think that newer version of NuGet package can be build now.

#15 solved the problem of targeting in .NET CORE.

pluskal added a commit to pluskal/kaitai_struct_csharp_runtime that referenced this issue Jul 17, 2020
Resolve "`Nullable<T>` for optional fields are call"

Closes kaitai-io#6

See merge request marta/kaitai_struct_csharp_runtime!14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants