Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escape sequence handling in JRuby 9.4.4.0 help output #133

Open
headius opened this issue Oct 9, 2023 · 0 comments
Open

Remove escape sequence handling in JRuby 9.4.4.0 help output #133

headius opened this issue Oct 9, 2023 · 0 comments

Comments

@headius
Copy link
Member

headius commented Oct 9, 2023

The code here handles jruby/jruby#7864 by checking for both escaped and unescaped output.

// JRuby 9.4.0.0 thru 9.4.3.0 always emit the escape sequence here (jruby/jruby#7864)
if (lines[1].startsWith("\033[1m")) {
assertThat(lines[1]).contains("jruby [switches] [--] [programfile] [arguments]");
} else {
assertThat(lines[1]).isEqualTo("Usage: jruby [switches] [--] [programfile] [arguments]");

That issue will be fixed in JRuby 9.4.4.0, so once we upgrade jruby-maven-plugins we can remove the extra check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant