Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stderr/stdout not captured properly on windows when writes are done from c stubs (using C stdout/stderr) #43

Open
hhugo opened this issue Nov 4, 2022 · 2 comments
Open

stderr/stdout not captured properly on windows when writes are done from c stubs (using C stdout/stderr) #43

hhugo opened this issue Nov 4, 2022 · 2 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@hhugo
Copy link

hhugo commented Nov 4, 2022 •
edited
Loading

see https://github.com/ocsigen/js_of_ocaml/actions/runs/3379238096/jobs/5610532404

Smaller repro https://github.com/hhugo/ppx_expect/actions/runs/3419832757/jobs/5693854697
@hhugo hhugo mentioned this issue Nov 4, 2022
Merged
@hhugo hhugo changed the title stderr not captured properly on windows stderr/stdout not captured properly on windows when writes are done from c stubs (using C stdout/stderr) Nov 8, 2022
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Nov 14, 2022
@hhugo
Copy link
Author

hhugo commented Feb 27, 2023

This issue might be due to the C stderr FILE not being flushed with fflush

@hhugo hhugo mentioned this issue Feb 27, 2023
Merged
@hhugo
Copy link
Author

hhugo commented Feb 27, 2023

I confirm that adding fflush(stderr) fixes the issue.
I'll let you decide whether it should be handled/fix in ppx_expect or not. If not, please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hhugo @github-iron