Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Directly provide payload to WASM entrypoints #5113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Directly provide payload to WASM entrypoints #5113

wants to merge 1 commit into from
+95 −275

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Oct 1, 2024

Context

Fixes #5074

Solution

From the issue:

when wasm is executed it's entrypoint function is always without arguments and does a callback to get_xxx_context to initialize. We should remove that (as it saves us one call to host) and directly provide an encoded argument when calling the entrypoint function.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@dima74 dima74 self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@dima74 dima74

Labels
None yet
Projects
Iroha
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove get_xxx_context functions from wasm
1 participant
@dima74