Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rust-toolchain.toml #5051

Open
mversic opened this issue Sep 10, 2024 · 2 comments
Open

Introduce rust-toolchain.toml #5051

mversic opened this issue Sep 10, 2024 · 2 comments

Comments

@mversic
Copy link
Contributor

mversic commented Sep 10, 2024

          How about we commit a `rust-toolchain.toml` file so that the developers get the rust version corresponding to what we have in CI right away?
[toolchain]
channel = "nightly-2024-09-09"

Originally posted by @DCNick3 in #5047 (comment)

@mversic
Copy link
Contributor Author

mversic commented Sep 10, 2024

Why did we remove it? @s8sato do you remember?

@s8sato
Copy link
Contributor

s8sato commented Sep 10, 2024

We had a docker build problem with the toolchain file, but as far as I remember we didn't figure out the cause. I guess it was maybe a toolchain mismatch between environments. I think it's worth introducing again, if we can eliminate hardcoded toolchains except for the toml content. Otherwise, we should be careful to keep hardcoded toolchains consistent with the toml content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants