Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare dependencies is included when is not used #205

Open
jlucaso1 opened this issue Jul 23, 2024 · 1 comment
Open

Cloudflare dependencies is included when is not used #205

jlucaso1 opened this issue Jul 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jlucaso1
Copy link

What version of HonoX are you using?

0.1.23

What steps can reproduce the bug?

Install hono, honox, vite and @hono/vite-dev-server
Check node_modules after install and will be like:
image

What is the expected behavior?

The cloudflare dependencies don't need to be downloaded or included in node_modules

What do you see instead?

A high usage of disk in node_modules. This can improve installs on CI/CD enviroments in general

Additional information

I'm using bun, but this bug occurs also in NPM

@jlucaso1 jlucaso1 added the bug Something isn't working label Jul 23, 2024
@yusukebe
Copy link
Member

Hi @jlucaso1

Thank you for the issue. It's a known issue for @hono/vite-dev-server. It depends miniflare to keep
backward compatibility:

https://github.com/honojs/vite-plugins/blob/fdd4b48e7833156360097960fe1dca0bbcafd845/packages/dev-server/package.json#L79

But, now, we may mind the backward compatibility. If so, we can remove it. Please wait a little to consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants