Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

registry.New outputs logging #25

Open
samifruit514 opened this issue Dec 20, 2016 · 1 comment · May be fixed by #33
Open

registry.New outputs logging #25

samifruit514 opened this issue Dec 20, 2016 · 1 comment · May be fixed by #33

Comments

@samifruit514
Copy link

registry.New is calling Ping() from newFromTransport method and Ping() outputs logging with

r.Logf("registry.ping url=%s", url).

We cannot set logging callback before New function. So it makes it impossible to mute that ping log line.
@wind0r wind0r linked a pull request Feb 6, 2017 that will close this issue
Open
@prune998
Copy link

prune998 commented Jun 1, 2018

I also made a PR #53

Sadly, the maintainer of this project seem to be... dead... 13 PR never merged...

kispaljr added a commit to nokia/docker-registry-client that referenced this issue Nov 13, 2018
@kispaljr
Introduce extendable constructor options and the NewCustom() constructor
d8d8507 
Fixes issues heroku#42 and heroku#25
Addresses the same problems as heroku#53, heroku#43 and heroku#33, but takes a different a approach
@kispaljr kispaljr mentioned this issue Nov 13, 2018
Open
@kkapelon kkapelon mentioned this issue Apr 28, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add log option to new wind0r/docker-registry-client
2 participants
@prune998 @samifruit514