You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We ran into this issue where draggable children can be substantially larger than the scrolling parent and, to my surprise after digging into your source code, I noticed you intentionally disable auto scrolling in these situations. I started to understand the implications after spending a couple of hours reading through, but I had the feeling this can be implemented in a fairly simple way.
Proposed solution
Use mouse position relative to scrolling container when determining the auto scroll direction instead
Remove adjustForSizeLimits logic
Change distanceToEdges from edge -> center to edge -> edge (fx top -> top,)
Hey @robertontiu! I stumbled across the same issue as you. Would you mind creating a PR with your fix? Maybe one of the devs will approve the fix. Thanks!
@CodrinSocol
I am reluctant to do this because a proper solution would most likely not use a global mousePosition variable and I'm not familiar enough with the code base (or have time at this point) to add that. I will leave it to the developers who actively maintain this library to do as they see fit. In the meantime, you can apply this patch with patch-package.
Description
We ran into this issue where draggable children can be substantially larger than the scrolling parent and, to my surprise after digging into your source code, I noticed you intentionally disable auto scrolling in these situations. I started to understand the implications after spending a couple of hours reading through, but I had the feeling this can be implemented in a fairly simple way.
Proposed solution
adjustForSizeLimits
logicdistanceToEdges
fromedge -> center
toedge -> edge
(fxtop -> top,
)Patch package diff
The text was updated successfully, but these errors were encountered: