Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, drop nix* prefix from function names #1010

Open
Anton-Latukha opened this issue Nov 8, 2021 · 0 comments
Open

Please, drop nix* prefix from function names #1010

Anton-Latukha opened this issue Nov 8, 2021 · 0 comments

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Nov 8, 2021

For example - a lot of functions inside Nix module are named nix*.

There is nixEval in Nix & eval in Eval. But nixEval really runs withNixContext from Builtins as evaluator. If it is confusing - because it is.

withNixContext is really execInsideNixContext, it actually does just a lot of pushScopes, functions in Nix then are also really exec.. ... actually I think dictionary should be expended there (maybe from interpreter/compiler theory), there are a lot of different eval & exec that do different eval & exec - it should be distinquished.

Nix (C++) instantiation-related function in the project also use nix* prefix, but in this case, it is more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant