Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccPubsubSubscription should use bootstrapped IAM #19683

Open
melinath opened this issue Sep 30, 2024 · 0 comments
Open

Comments

@melinath
Copy link
Collaborator

melinath commented Sep 30, 2024

Impacted tests

  • TestAccPubsubSubscription_pubsubSubscriptionPushBqExample
  • TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample

These are failing (at least sometimes) on PRs but passing in nightly tests

Affected Resource(s)

  • google_pubsub_subscription

Failure rates

Unknown. See GoogleCloudPlatform/magic-modules#11834 (comment) for an example failure.

Message(s)

resource_pubsub_subscription_generated_test.go:245: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          + create
        
        Terraform will perform the following actions:
        
          # google_project_iam_member.editor will be created
          + resource "google_project_iam_member" "editor" {
              + etag    = (known after apply)
              + id      = (known after apply)
              + member  = "serviceAccount:[email protected]"
              + project = "ci-test-project-188019"
              + role    = "roles/bigquery.dataEditor"
            }
        
          # google_project_iam_member.viewer will be created
          + resource "google_project_iam_member" "viewer" {
              + etag    = (known after apply)
              + id      = (known after apply)
              + member  = "serviceAccount:[email protected]"
              + project = "ci-test-project-188019"
              + role    = "roles/bigquery.metadataViewer"
            }
        
        Plan: 2 to add, 0 to change, 0 to destroy.

These examples should use the bootstrap utils for IAM instead. https://github.com/hashicorp/terraform-provider-google/blob/main/google/acctest/bootstrap_iam_test_utils.go

Examples: https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fmagic-modules%20BootstrapPSARole&type=code

Nightly build test history

N/A

b/370524138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants