Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API gateway support for google_compute_network_endpoint_group was never implemented but release notes say it was #19567

Closed
red8888 opened this issue Sep 23, 2024 · 2 comments · Fixed by hashicorp/terraform-provider-google-beta#8302

Comments

@red8888
Copy link

red8888 commented Sep 23, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform v1.9.5
on darwin_arm64

  • provider registry.terraform.io/hashicorp/google v6.3.0
  • provider registry.terraform.io/hashicorp/google-beta v6.3.0
  • provider registry.terraform.io/hashicorp/random v3.6.3

Affected Resource(s)

google_compute_network_endpoint_group

Terraform Configuration

resource "google_compute_network_endpoint_group" "serverless_neg" {
  provider = google-beta
  name = "SERVERLESS_NEG_NAME"
  network_endpoint_type = "SERVERLESS"
  serverless_deployment {
    platform = "apigateway.googleapis.com"
    resource = "GATEWAY_ID"
  }
}

I also tried this

resource "google_compute_region_network_endpoint_group" "serverless_neg" {
  provider = google-beta
  name     = "SERVERLESS_NEG_NAME"
  region  = "REGION_ID"
  network_endpoint_type = "SERVERLESS"
  serverless_config {
    platform = "apigateway.googleapis.com"
    gateway_id = "GATEWAY_ID"
  }
}

Debug Output

No response

Expected Behavior

See this release note: https://github.com/hashicorp/terraform-provider-google-beta/blob/main/CHANGELOG.md#4120-february-28-2022. "compute: added field serverless_deployment to google_compute_network_endpoint_group (beta only) for API Gateway resources (hashicorp/terraform-provider-google-beta#4041)"

And these issues:

I'm using the beta provider and its not there. I can also find zero working examples or docs for this feature that was merged years ago.

Actual Behavior

│ Error: Unsupported block type
│ 
│   on api_gateway.tf line 33, in resource "google_compute_network_endpoint_group" "serverless_neg":
│   33:   serverless_deployment {
│ 
│ Blocks of type "serverless_deployment" are not expected here.

Steps to reproduce

  1. terraform apply

Important Factoids

No response

References

No response

b/369904931

@red8888 red8888 added the bug label Sep 23, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-networking-neg labels Sep 23, 2024
@ggtisc ggtisc self-assigned this Sep 25, 2024
@ggtisc ggtisc added documentation and removed bug labels Sep 25, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Sep 26, 2024

Confirmed documentation issue!

Currently there isn't any argument called serverless_deployment in terraform registry. It is just a mistake in the release note.

@ggtisc ggtisc removed the forward/review In review; remove label to forward label Sep 26, 2024
@ggtisc ggtisc removed their assignment Sep 26, 2024
@Cheriit
Copy link

Cheriit commented Sep 27, 2024

I see that there was an issue with the release notes.

Instead of "compute: added field serverless_deployment to google_compute_network_endpoint_group (beta only)" it should be "compute: added field serverless_deployment to google_compute_region_network_endpoint_group (beta only)".

Serverless only available for the google_compute_region_network_endpoint_group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants