fallback to hashicorp namespace if none is passed in go provider generation

[ansgarm]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Imports for generated providers in Go are currently nested according to their namespace.
So, for example:

"cdk.tf/go/stack/generated/hashicorp/random"

However, this only happens if the namespace is explicitly passed in cdktf.json:

"terraformProviders": ["hashicorp/random@~> 3.1.0"],

As the shorthand without the prefix hashicorp/ is also allowed for official providers, this:

"terraformProviders": ["random@~> 3.1.0"],

should also result in the same import to work.

But, as the implementation currently does not fall back to hashicorp for an empty namespace, it results in generated code that needs to be imported from another directory:

"cdk.tf/go/stack/generated/random"

It should always have the same import name.

References

• This is a follow-up for fix(tests): adjust terraform provider name to match imports used in main.go #727

[danieldreier]

This is a good pragmatic approach, but we should also print a warning or informational message when we do this. There is a long-term effort across Core and the registry to move away from implicit hashicorp namespacing, so we should help nudge people in the right direction if they omit the hashicorp namespace.

[mutahhir]

After #2146 hashicorp will be cdktf now, but Daniel's point stands regarding informational message.