Various theme contrast issues 😬

[chriskrycho]

I'm back with more error reports for your excellent extension. 😁 Two issues with the Nord theme for you.

The Nord Light variation is… just broken. 😬

The dark variation looks great… except for the status bar:

[chriskrycho]

There are similar problems with contrast in the Cupertino themes.

[chriskrycho]

And with Mellow Purple!

[golf1052]

So I just checked out these themes on https://chriskempson.github.io/base16/ (well technically my updated fork -> https://github.com/golf1052/base16/tree/gh-pages) and for all three of these themes it looks like they just don't work as light themes.

The way I would prefer to solve this would be to block these three light themes from being generated. Since I'm pulling these themes from their respective repos I would rather defer to the theme creator to create a nice light version for their theme.

In the Cupertino case I would leave it as a light theme only and not generate the dark theme.

[chriskrycho]

Yeah, doing it the same (albeit inverted) as the GitHub theme seems right.

Note that it won’t solve the status bar problem on Nord Dark (which is actually what sent me poking around at the others).

[chriskrycho]

Note re:Nord, there's an official Nord repository upstream.

If you want, I can submit a PR over the weekend to remove the ones that look really bad.

[golf1052]

A PR would be great.

[Hedroed]

Hello
I made a fixed version of the nord dark theme.

base16-nord-dark.json.txt
Named .txt because github doesn't recognize .json.