Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbsURL tests #2147

Closed
amitsaha opened this issue May 14, 2016 · 5 comments
Closed

AbsURL tests #2147

amitsaha opened this issue May 14, 2016 · 5 comments
Labels

Comments

@amitsaha
Copy link
Contributor

I came across this test of the absolute URL function (in helpers/url_test.go):

{"/test/2/foo/", "http://base/path", "http://base/test/2/foo/"},

Shouldn't the right result be http://base/path/test/2/foo ?

@bep
Copy link
Member

bep commented May 14, 2016

Why?

@amitsaha
Copy link
Contributor Author

What do you mean "why"? If my blog is hosted at "http://example.com/mysite", I want the CSS path to be "http://example.com/mysite/css/style.css" and not "http://example.com/css/style.css".

@bep
Copy link
Member

bep commented May 14, 2016

"/test/2/foo/" is an URL that is relative to the server root.
"test/2/foo/" is an URL that is relative to the context root.

The tests are correct, and there is no problem creating CSS paths as in your examples.

@bep bep closed this as completed May 14, 2016
@amitsaha
Copy link
Contributor Author

amitsaha commented Jul 1, 2016

I suspect it's an issue with the theme I was using, let's see: zyro/hyde-x#67

marvinpinto added a commit to marvinpinto/ledger-reconciler that referenced this issue Sep 10, 2017
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants