Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize permissions required for circleci migrator #34238

Open
1 task done
jsoref opened this issue Aug 7, 2024 · 3 comments
Open
1 task done

harmonize permissions required for circleci migrator #34238

jsoref opened this issue Aug 7, 2024 · 3 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 7, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/migrating-from-circleci-with-github-actions-importer#configuring-credentials

What part(s) of the article would you like to see updated?

Create a GitHub personal access token (classic). For more information, see "Managing your personal access tokens."

Your token must have the workflow scope.

After creating the token, copy it and save it in a safe location for later use.

https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/migrating-from-circleci-with-github-actions-importer#using-environment-variables

GitHub Actions Importer uses the following environment variables to connect to your CircleCI instance:

GITHUB_ACCESS_TOKEN: The personal access token (classic) used to create pull requests with a converted workflow (requires repo and workflow scopes).

Additional information

It's possible these sections aren't talking about the same thing, but that feels unlikely, and as I've tripped on an error that seems related, it feels like a bug.

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Aug 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 7, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 7, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks for opening an issue! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the needs SME This proposal needs review from a subject matter expert label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while our SME team reviewed! They wanted to relay the following -

We need both perms, thank you for helping clean up our docs!

We need both perms for the following reasons:

  • Workflow Permission: Required to create and update GitHub Actions workflows using GitHub Actions Integration (GAI).
  • Repo Permission: Necessary to open a pull request against the repository that includes the new workflow created with GAI.

I've added the help wanted label so that you, or anyone else, can raise a PR to update the doc to state both permissions are needed 💛

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants
@jsoref @nguyenalex836 and others