Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop transpilation #217

Closed
ta2edchimp opened this issue Nov 15, 2017 · 2 comments
Closed

Drop transpilation #217

ta2edchimp opened this issue Nov 15, 2017 · 2 comments

Comments

@ta2edchimp
Copy link
Collaborator

IMO we should drop the transpilation step when releasing a revived version. I just had a (very) quick look into the sources and do not see anything that really requires us to transpile, when we would drop support for older Node versions at least.

This would have the benefit of being able to also npm install ghooks from its repo or from a fork (like described here: #216 ), using it right away instead of having to cope with the transpilation step (dist folder being only created upon build, prior to publishing) and its requirements (e.g. having babel installed).
@gtramontina
Copy link
Collaborator

Yeah, my memory is failing on reminding me the reasons why we added babel (I'm on my phone, kinda painful to go through the git history to find out). My guess would be to support old node versions, as you mentioned. I'm all for it!

@gtramontina gtramontina mentioned this issue Nov 21, 2017
Merged
@gtramontina
Copy link
Collaborator

Closed by #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ta2edchimp @gtramontina