Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The creator of migrated alerts are the account of redash-migrate #88

Open
yu-iskw opened this issue Oct 20, 2021 · 2 comments
Open

The creator of migrated alerts are the account of redash-migrate #88

yu-iskw opened this issue Oct 20, 2021 · 2 comments

Comments

@yu-iskw
Copy link

yu-iskw commented Oct 20, 2021

Issue

I run redash-migrate alerts with a test environment from the hosted redash, the creator of migrated alerts are the account of redash-migrate, not the original creators. In the case below, I created the test account to migrate whose name is redash-admin.

Alerts

Expected behaviors

The creators have to be the same as those in the original environment.

@yu-iskw yu-iskw changed the title The creator of migrated alerts are the account of redash-migrate The creator of migrated alerts should be the account of redash-migrate Oct 21, 2021
@yu-iskw yu-iskw changed the title The creator of migrated alerts should be the account of redash-migrate The creator of migrated alerts are the account of redash-migrate Oct 21, 2021
@yu-iskw
Copy link
Author

yu-iskw commented Oct 21, 2021

The issues appears on queries as well.
Queries

@susodapop
Copy link
Collaborator

Two things are happening here:

Alerts

What you describe is currently the expected behaviour. The code does not try to retain the original alert creator. We can change this. It was not a priority at first because anyone can edit an alert regardless who created it (not the same for queries / dashboards).

Queries

What you describe is not the expected behaviour. Per this line, we create a user client which creates each query. This way the original creator of a query is retained after migration. If this is not happening for you then we need to see reproduction steps as this is a significant issue.

If you can provide reproduction steps, please open a second issue so we can track and prioritise it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants