Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): Improve UX of runtime heuristics tests #4248

Open
breathx opened this issue Sep 23, 2024 · 0 comments · May be fixed by #4252
Open

refactor(tests): Improve UX of runtime heuristics tests #4248

breathx opened this issue Sep 23, 2024 · 0 comments · May be fixed by #4252
Assignees
@Lazark0x

Comments

@breathx
Copy link
Member

breathx commented Sep 23, 2024

Tests scope:

  • instruction_weights_heuristics_test
  • syscall_weights_test
  • page_costs_heuristic_test
  • lazy_page_costs_heuristic_test

Atm these tests are panicking on the first mismatch. Deprecate this fail-fast behaviour in favour of comparing all of the parts with upcoming general panic with the list of all names mismatched
@Lazark0x Lazark0x self-assigned this Sep 23, 2024
@Lazark0x Lazark0x linked a pull request Sep 24, 2024 that will close this issue
Heuristics tests are altered to panic with multiple results #4252
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lazark0x Lazark0x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Heuristics tests are altered to panic with multiple results gear-tech/gear
2 participants
@Lazark0x @breathx