Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Source: Unit mA cut off on devices with smaller screens #2526

Open
marcnause opened this issue Aug 4, 2024 · 5 comments
Open

Power Source: Unit mA cut off on devices with smaller screens #2526

marcnause opened this issue Aug 4, 2024 · 5 comments

Comments

@marcnause
Copy link
Contributor

Actual Behaviour

The unit mA in the EditText of PCS is cut off in horizontal mode. (Test device: Moto X Play)

Expected Behaviour

Units are always fully visiblel.

Steps to reproduce it

  1. Start app
  2. Go to Power Source
  3. Change to horizontal orientation

Screenshots of the issue

@Dishebh
Copy link
Member

Dishebh commented Sep 10, 2024

Hey @marcnause , does the issue still exist? I tried reproducing it in various dimensions in landscape mode, but couldn't see the issue. Could I be missing something?

@marcnause
Copy link
Contributor Author

marcnause commented Sep 10, 2024

@Dishebh I tested with my Moto X Play and I still see the cut off unit for PCS ("m" instead of "mA").

I have created a hardware profile which can be used to create a virtual device which has a similar screen as the real hardware:
moto_x_play.zip

I had to compress the file since it is not possible to attach XML files here.

The file must be unzipped and can be imported in the Virtual Device Configuration via the "Import Hardware Profiles" button.

When I run PSLab in the virtual device, go to the Power Source and turn the device right (Command + R), I get the same result as with the real hardware.

@Dishebh
Copy link
Member

Dishebh commented Sep 15, 2024

Thanks a lot @marcnause , will check this out!

@Dishebh
Copy link
Member

Dishebh commented Sep 29, 2024

Hey @marcnause , I was able to reproduce the issue. I can see it happening for values that may come in 4 decimal places, or when the resolution is low. Just to understand, what's the best way to solve this? Should the numbers get resized automatically as and when they are increased, so that every digit of the number is always visible?

@marcnause
Copy link
Contributor Author

Should the numbers get resized automatically as and when they are increased, so that every digit of the number is always visible?

Yes, if that's possible, I think it would be a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants