Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Native Image Picker #36

Open
fdocr opened this issue Jun 10, 2021 · 0 comments
Open

Refactor Native Image Picker #36

fdocr opened this issue Jun 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@fdocr
Copy link
Contributor

fdocr commented Jun 10, 2021

Is your feature request related to a problem? Please describe.

For our first version we chose YPImagePicker because of their easy to use API and the fact that it supported all our requirements (basic Image Picker + camera photo + image crop) with the added benefit of adding filters (à la Instagram) with a nice interface.

However, we do have a few problems with it:

  • It adds a few upstream dependencies that impact apps that use our framework
  • It supports SPM but only on a separate branch and this causes us to be unable to rely on versioned releases
    • The SPM branch is also far behind the recent work merged to the project itself, which raises many deprecation warnings on projects that import our framework

There are some efforts to fix the problem of SPM not being fully supported but we should probably look into implementing our own solution.

Describe the solution you'd like

A simple image picker that provides two choices when triggered (use photo from library or take a picture with the camera). After a photo is chosen, if a ratio is provided then proceed with a cropping stage. This image picker would replace the YPImagePicker implementation in this function.

By implementing the image picker using SwiftUI we could greatly reduce the transitive dependencies added to projects downstream from us.

Describe alternatives you've considered

We can look into other OSS Image Pickers but I would definitely favor implementing our own lightweight picker to reduce the impact of adding dependencies to projects downstream from us.

Additional context

N/A

@fdocr fdocr added the enhancement New feature or request label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant