Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon is missing in KDE #5

Open
garrett opened this issue Mar 8, 2022 · 2 comments
Open

Icon is missing in KDE #5

garrett opened this issue Mar 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@garrett
Copy link

garrett commented Mar 8, 2022

When using Cockpit Client in KDE, the icon is missing. I think this is a problem with the Flatpakization, as the icon does show up in Flathub and also in GNOME just fine. Additionally, the icon in the launcher is poor quality and is missing transparency.

So we might be missing a line here in the YML @ https://github.com/flathub/org.cockpit_project.CockpitClient/blob/master/org.cockpit_project.CockpitClient.yml

Perhaps we need a special install line similar to the metainfo, but for the SVG?

post-install:
- install -Dt /app/share/metainfo ${FLATPAK_ID}.metainfo.xml

Something like this, perhaps:

      - install -D -t ${FLATPAK_DEST}/share/icons/hicolor/scalable/apps org.cockpit_project.CockpitClient.svg
      - install -D -t ${FLATPAK_DEST}/share/icons/hicolor/128x128/apps org.cockpit_project.CockpitClient.png

(It should be the case that only an SVG is needed, but when I was flatpaking Lunacy, the builder complained about not having a 128px PNG, so I included an export of the SVG.)

@garrett
Copy link
Author

garrett commented Mar 8, 2022

Here's a screenshot from Kinoite (Fedora Silverblue, but with KDE instead) in a VM:

Screenshot from 2022-03-08 17-01-44

When in Wayland, the taskbar has a default Wayland icon. When in X11, it has a default X11 icon. The launcher ("Kicker", aka: KDE's "start menu") has a messed up icon.

Zoomed in icons:

Screenshot from 2022-03-08 17-01-44-wayland
Screenshot from 2022-03-08 17-01-44-launcher

And here's the same, but in X11 instead of Wayland:

Screenshot from 2022-03-08 17-00-54

@garrett
Copy link
Author

garrett commented Mar 8, 2022

@jelly is seeing the same thing on Steam Deck's KDE desktop, so this isn't a VM thing or isolated to Fedora.

@martinpitt martinpitt added the bug Something isn't working label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants